Workaround to fix flaky LSP test #977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A non-show-tree version of Core should be somewhat stable since we pretty-print it? |
|
Alternatively, we could also check modulo whitespace (i.e. replace all sequences of whitespace characters with |
This is what I implemented now. |
marzipankaiser
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated identifiers in the IR seem non-deterministic between execution environments: one can observe different names locally vs on the CI.
This led to test failures in entirely unrelated PRs (#930, #923).
As this is blocking the other PRs, I propose the hotfix contained in this PR. I'm also open to better suggestions on how to write this particular test case or on how to fix the non-determinism.